Skip to content

Expose proxy settings for Ruby Faraday#11692

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
quiltt:master
Feb 26, 2022
Merged

Expose proxy settings for Ruby Faraday#11692
wing328 merged 1 commit intoOpenAPITools:masterfrom
quiltt:master

Conversation

@sirwolfgang
Copy link
Copy Markdown
Contributor

@sirwolfgang sirwolfgang commented Feb 22, 2022

Expose Faraday Proxy Settings.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@sirwolfgang
Copy link
Copy Markdown
Contributor Author

Additionally it looks like the build_request is wiping out all faraday default connection options

@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 23, 2022

@sirwolfgang thanks for the PR. Let us know when it's ready for review.

@sirwolfgang
Copy link
Copy Markdown
Contributor Author

@wing328 Hey, thanks. Codewise, I think this is complete, I am running in a monkey patch downstream. I am however not sure about the failing specs, or how to appropriately add new specs. I am a little off-sides with this toolchain. Is this something you can help get over the line?

@sirwolfgang sirwolfgang marked this pull request as ready for review February 25, 2022 16:30
@wing328 wing328 added this to the 6.0.0 milestone Feb 25, 2022
@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 26, 2022

@wing328 wing328 merged commit 51ecfcd into OpenAPITools:master Feb 26, 2022
@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 26, 2022

FYI. Samples updated via 1cd4f3b

@sirwolfgang
Copy link
Copy Markdown
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants