Skip to content

validate pom.xml files#11672

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
sullis:validate-pom-xml-files
Feb 23, 2022
Merged

validate pom.xml files#11672
wing328 merged 1 commit intoOpenAPITools:masterfrom
sullis:validate-pom-xml-files

Conversation

@sullis
Copy link
Copy Markdown
Contributor

@sullis sullis commented Feb 20, 2022

use the OpenRewrite Maven parser to verify that the pom.xml is valid.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@sullis sullis force-pushed the validate-pom-xml-files branch from e7a8752 to 6f91268 Compare February 20, 2022 17:43
@sullis sullis force-pushed the validate-pom-xml-files branch from 6f91268 to 7de7a10 Compare February 21, 2022 19:41
@sullis sullis marked this pull request as ready for review February 21, 2022 19:50
@sullis sullis requested a review from wing328 February 21, 2022 19:50
@wing328 wing328 added this to the 6.0.0 milestone Feb 23, 2022
@wing328 wing328 merged commit 6e7c39e into OpenAPITools:master Feb 23, 2022
@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 23, 2022

LGTM 👍

@sullis sullis deleted the validate-pom-xml-files branch February 27, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants