Remove dummy variable declaration for context.Context from generated go code#11641
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Feb 18, 2022
Merged
Conversation
…go code Originally, this dummy declaration was needed because there was the possibility of the generated code doesn't use `context.Context` and then if it imported that package, go compiler complains that and makes an error. ref: https://github.com/OpenAPITools/openapi-generator/blob/3ed1aa8e79687bed63dfa064de27317273080471/modules/swagger-codegen/src/main/resources/go/api.mustache#L30 However, now this dummy placement is no longer needed because the generated code always uses `context.Context`. Signed-off-by: moznion <[email protected]>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, this dummy declaration was needed because there was the possibility of the generated code doesn't use
context.Contextand then if it imported that package, go compiler complains that and makes an error.ref:
openapi-generator/modules/swagger-codegen/src/main/resources/go/api.mustache
Line 30 in 3ed1aa8
However, now this dummy placement is no longer needed because the generated code always uses
context.Context.So this pull request removes that dummy declaration.
cc. @antihax @grokify @kemokemo @jirikuncar @ph4r5h4d
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x