Skip to content

Bug Fix: Cast from QByteArray to std::runtime_error#11594

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
itay-grudev:patch-1
Feb 26, 2022
Merged

Bug Fix: Cast from QByteArray to std::runtime_error#11594
wing328 merged 1 commit intoOpenAPITools:masterfrom
itay-grudev:patch-1

Conversation

@itay-grudev
Copy link
Copy Markdown
Contributor

I am compiling this on a sligthtly older Qt version (Qt 5.6) with a slightly older compiler and I encounter the following error:

error: no matching conversion for functional-style cast from 'QByteArray' to 'std::runtime_error'

This is easily mitigated and the solution is forward-compatible. The problem is simply because of mising cast operator from QByteArray to std::string on older Qt version. This solution should support all Qt versions.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd

```
error: no matching conversion for functional-style cast from 'QByteArray' to 'std::runtime_error'
```
@itay-grudev
Copy link
Copy Markdown
Contributor Author

Are these test failures caused by me or are they just flaky?

@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 26, 2022

@wing328 wing328 merged commit 03f3fd0 into OpenAPITools:master Feb 26, 2022
@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 26, 2022

@itay-grudev thanks for the PR, which has been merged into the master. Samples updated via c3c8251

@wing328 wing328 added this to the 6.0.0 milestone Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants