Skip to content

[Python] python regex validation generation#11525

Merged
spacether merged 3 commits intoOpenAPITools:masterfrom
aaronatbissell:fix_issue11521
Feb 18, 2022
Merged

[Python] python regex validation generation#11525
spacether merged 3 commits intoOpenAPITools:masterfrom
aaronatbissell:fix_issue11521

Conversation

@aaronatbissell
Copy link
Copy Markdown
Contributor

@aaronatbissell aaronatbissell commented Feb 5, 2022

This removes some code that was not correctly generating regex validation patterns. It's basically a revert of #10920 and fixes #11521.

Technical team:
@taxpon
@frol
@mbohlool
@cbornet
@kenjones-cisco
@tomplus
@Jyhess
@arun-nalla
@spacether

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether
Copy link
Copy Markdown
Contributor

node0 error looks unrelated

Copy link
Copy Markdown
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

@spacether spacether added this to the 6.0.0 milestone Feb 18, 2022
@spacether spacether merged commit 0d4dba1 into OpenAPITools:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][Python] Client generation doesn't handle regex pattern correctly

2 participants