Fix ClassCastException if expected type is Object#11510
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Feb 5, 2022
Merged
Fix ClassCastException if expected type is Object#11510wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
The currently generated code will throw a `ClassCastException` if `type` is `Object`. I'm not quite sure why `isAssignableFrom` is used here but I tried to keep the change minimal - in my understanding, the result would be the same if the line was
```
if(Types.getRawType(type).equals(ApiResponse.class)) {
```
because the `ApiResponse` only extends `Object` and implements no interfaces. Maybe it was meant to be `ApiResponse.class.isAssignableFrom(Types.getRawType(type))`? This would also permit subclasses of `ApiResponse`, but then it would be more complicated to determine the actual type parameter (because `type` itself may not be parameterized) and to create the object to return (because it would have to be an instance of the subclass).
Member
|
Tested locally with updated samples and the result is ok |
Member
|
@lbilger thanks for the PR, which has been merged. Next time please follow step 3 in the PR checklist so that the CI can verify the results with updated samples. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The currently generated code will throw a
ClassCastExceptioniftypeisObject. I'm not quite sure whyisAssignableFromis used here but I tried to keep the change minimal - in my understanding, the result would be the same if the line wasbecause the
ApiResponseonly extendsObjectand implements no interfaces. Maybe it was meant to beApiResponse.class.isAssignableFrom(Types.getRawType(type))? This would also permit subclasses ofApiResponse, but then it would be more complicated to determine the actual type parameter (becausetypeitself may not be parameterized) and to create the object to return (because it would have to be an instance of the subclass).Fixes #11509
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
The build did not work locally, probably because I don't have Java 8 installed anyomore. As it's a really small change, I hope that will be ok...
master(5.3.0),6.0.x@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)