Add compilation test to typescript-angular-v13-provided-in-root petst…#11471
Add compilation test to typescript-angular-v13-provided-in-root petst…#11471wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
|
@amakhrov can you check this if travis builds? thanks. |
|
the error on ci/circleci: node0 does not appear to be related to this change? |
|
@cghislai it doesn't seem related, right. However, it's suspicious that both your PRs have the same failure. I can see 2 recently merged PRs related to spring-mvc generator (the one that fails in your PR). Is it possible that your branch is behind |
|
i was lagging by 1 commit. I could generate the spring-mvc sample javadoc locally. I see there is a file encoding error, and that it is triggered when the samples input changed (and |
|
I will wait for #11477 to be merged to fix circleci builds then rebase |
…d-in-root using petstore v3
|
@amakhrov, the build errors have been fixed. can you have another look? |
…ore sample
This adds a simple test to ensure the generated typescript-angular-v13-provided-in-root code is compilable.
This would prevent issues such as #10975, #10864, or #11172 (all duplicates) to occur.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x