[Java/Spring] Revert to fully qualified import for org.springframework.core.io.Resource#11461
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Jan 31, 2022
Conversation
Contributor
Author
|
@wing328 FYI |
Contributor
Author
|
@welshm What do you think should be the default in 5.4.0? |
Contributor
IMO I would default to OAS2 / SpringFox for backwards compatibility and change the default in 6.0. Easy enough for people who want it to set the correct configurations and doesn't break people who just want stability improvements from the generator update |
Member
5.4.0 allows breaking changes with fallback so it's ok to do so |
Contributor
Author
|
Ok, then we go for Springdoc (OAS3). |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last Minute correction:
Revert to fully qualified import for
org.springframework.core.io.ResourceOn final Decision:
Springdoc (OAS3) is the default Documentation Provider since (#11258)
Should we set it to Springfox (OAS2) for 5.4.0, switching the default in 6.0?
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x