Skip to content

[csharp-netcore]: Remove unused UrlEncode method from csharp-netcore template.#11453

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
jafin:tidy/csharp-remove-urlEncode
Feb 7, 2022
Merged

[csharp-netcore]: Remove unused UrlEncode method from csharp-netcore template.#11453
wing328 merged 1 commit intoOpenAPITools:masterfrom
jafin:tidy/csharp-remove-urlEncode

Conversation

@jafin
Copy link
Copy Markdown
Contributor

@jafin jafin commented Jan 30, 2022

🐉 Possible breaking change: Method is public so upstream consumer may of used it, but library does not require it.

  • ClientUtils.UrlEncode method removed.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and
  • update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05)

…ing change: Method is public so upstream consumer *may* of used it, but library does not.
@devhl-labs
Copy link
Copy Markdown
Contributor

I don't see it in use anywhere. LGTM

@wing328 wing328 added Breaking change (without fallback) Client: C-Sharp Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Feb 7, 2022
@wing328 wing328 added this to the 6.0.0 milestone Feb 7, 2022
@wing328 wing328 merged commit dbb63dc into OpenAPITools:master Feb 7, 2022
@wing328 wing328 changed the title tidy [csharp-netcore]: Remove unused UrlEncode method from csharp-netcore template. [csharp-netcore]: Remove unused UrlEncode method from csharp-netcore template. Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking change (without fallback) Client: C-Sharp Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants