Skip to content

[crystal][client] Fix crystal code gen null pointer exception error in constructExampleCode#11437

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
cyangle:master
Jan 29, 2022
Merged

[crystal][client] Fix crystal code gen null pointer exception error in constructExampleCode#11437
wing328 merged 1 commit intoOpenAPITools:masterfrom
cyangle:master

Conversation

@cyangle
Copy link
Copy Markdown
Contributor

@cyangle cyangle commented Jan 29, 2022

Checks if codegenParameter.items is null in constructExampleCode

Fix NullPointerException in constructExampleCode

Spec file to reproduce the issue: https://github.com/stripe/openapi/raw/master/openapi/spec3.json

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Checks if codegenParameter.items is null in constructExampleCode
@wing328
Copy link
Copy Markdown
Member

wing328 commented Jan 29, 2022

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jan 29, 2022

Thanks for the fix. Tested locally and confirmed this PR fixes the NPE issue.

@wing328 wing328 merged commit d8f70b3 into OpenAPITools:master Jan 29, 2022
@wing328 wing328 added this to the 5.4.0 milestone Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants