Skip to content

[aspnetcore] Removes private setter when model property is readonly.#11416

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
mdulisch:patch-1
Apr 26, 2022
Merged

[aspnetcore] Removes private setter when model property is readonly.#11416
wing328 merged 1 commit intoOpenAPITools:masterfrom
mdulisch:patch-1

Conversation

@mdulisch
Copy link
Copy Markdown
Contributor

@mdulisch mdulisch commented Jan 26, 2022

When generating a library with the aspnetcore generator, model properties marked with a readonly flag are only private. As the server should be able to write these fields, they should not be marked as private.

As far as I understood the readonly property of the OAS correctly, the client can not set the property. But the server should be able to.

image
https://swagger.io/specification/

#11415

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Removed private setter when model property is `readonly`.
@mdulisch mdulisch marked this pull request as ready for review January 26, 2022 12:15
@mdulisch
Copy link
Copy Markdown
Contributor Author

@mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti

@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 26, 2022

LGTM but I've not tested it locally.

Thanks for the PR.

@wing328 wing328 merged commit c5e6c5f into OpenAPITools:master Apr 26, 2022
@wing328 wing328 added this to the 6.0.0 milestone Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants