[typescript] Adding Custom Agent Support for fetch call#11400
Merged
TiFu merged 9 commits intoOpenAPITools:masterfrom Jan 28, 2022
Merged
[typescript] Adding Custom Agent Support for fetch call#11400TiFu merged 9 commits intoOpenAPITools:masterfrom
TiFu merged 9 commits intoOpenAPITools:masterfrom
Conversation
macjohnny
reviewed
Jan 25, 2022
Member
macjohnny
left a comment
There was a problem hiding this comment.
Thanks for the contribution, looks good.
Can you please revert the deleted files and update the samples?
Contributor
Author
|
yep merging master back in now |
Member
|
@TiFu are you fine with this change? |
Contributor
Author
|
ended up excluding the web fetch since the lib doesn't list agent support, so it's just for the nodejs |
TiFu
approved these changes
Jan 28, 2022
Contributor
TiFu
left a comment
There was a problem hiding this comment.
LGTM! Thank you for the PR! :)
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
agent: http.Agent | https.Agent | undefinedinstance variable on theRequestContextclass as well as the following methods:Then, the isomorphic fetch implementation would call
getAgent()to pass the value into theagentoption on thefetchcall inisomorphic-fetch.tsImplements #11394
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov