Skip to content

[typescript-axios] Add stringEnums option#11368

Merged
macjohnny merged 12 commits intoOpenAPITools:masterfrom
ty-v1:add-string-enums-option-to-axios-generator
Jan 29, 2022
Merged

[typescript-axios] Add stringEnums option#11368
macjohnny merged 12 commits intoOpenAPITools:masterfrom
ty-v1:add-string-enums-option-to-axios-generator

Conversation

@ty-v1
Copy link
Copy Markdown
Contributor

@ty-v1 ty-v1 commented Jan 21, 2022

This PR adds stringEnums option to typescript-axios generator.
Closes #10943

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

macjohnny
macjohnny reviewed Jan 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Comment thread modules/openapi-generator/src/main/resources/typescript-axios/modelEnum.mustache Outdated
Comment thread ...generator/src/main/java/org/openapitools/codegen/languages/TypeScriptAxiosClientCodegen.java Outdated
Comment thread samples/client/petstore/typescript-axios/builds/composed-schemas/api.ts Outdated
@macjohnny macjohnny added this to the 5.4.0 milestone Jan 21, 2022
@ty-v1 ty-v1 force-pushed the add-string-enums-option-to-axios-generator branch from eeeec38 to b67e5ac Compare January 23, 2022 06:59
@macjohnny
Copy link
Copy Markdown
Member

macjohnny commented Jan 24, 2022 •
edited
Loading

@ty-v1 can you update the samples please? you need to add samples/client/petstore/typescript-axios/builds/with-string-enums/, see https://github.com/OpenAPITools/openapi-generator/runs/4919491575?check_suite_focus=true

@ty-v1
Copy link
Copy Markdown
Contributor Author

ty-v1 commented Jan 28, 2022 •
edited
Loading

Sorry, I could not work on it because I bought a new PC.
Now that the setup is complete, I'll update the samples.

@ty-v1 ty-v1 requested a review from macjohnny January 28, 2022 06:02
macjohnny
macjohnny approved these changes Jan 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ty-v1 ty-v1 force-pushed the add-string-enums-option-to-axios-generator branch from 57ae756 to 786d76c Compare January 28, 2022 15:16
macjohnny
macjohnny reviewed Jan 28, 2022
View reviewed changes
Comment thread modules/openapi-generator/src/main/resources/typescript-axios/modelObjectEnum.mustache Outdated
@macjohnny macjohnny merged commit 088c65c into OpenAPITools:master Jan 29, 2022
@kasperpeulen
Copy link
Copy Markdown
Contributor

kasperpeulen commented Feb 1, 2022

Would be great to have this for typescript-fetch as well @ty-v1

@kasperpeulen kasperpeulen mentioned this pull request Feb 1, 2022
Closed
@mkusaka mkusaka mentioned this pull request Mar 27, 2022
Merged
5 tasks
@StefanKern StefanKern mentioned this pull request Jun 28, 2022
Open
@ty-v1 ty-v1 deleted the add-string-enums-option-to-axios-generator branch July 7, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macjohnny macjohnny macjohnny approved these changes

Assignees

No one assigned

Labels

Breaking change (with fallback) Client: TypeScript

Projects

None yet

Milestone

5.4.0

Development

Successfully merging this pull request may close these issues.

[REQ] [typescript-axios] Object value enums

3 participants

@ty-v1 @macjohnny @kasperpeulen