Skip to content

[typescript-rxjs] Add RxJS 7 support#11364

Closed
jopelle1 wants to merge 2 commits intoOpenAPITools:masterfrom
m19-dev:feature/rxjs-7
Closed

[typescript-rxjs] Add RxJS 7 support#11364
jopelle1 wants to merge 2 commits intoOpenAPITools:masterfrom
m19-dev:feature/rxjs-7

Conversation

@jopelle1
Copy link
Copy Markdown

This PR adds support for RxJS 7.
Related PR : #9958

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

@macjohnny
Copy link
Copy Markdown
Member

@jopelle1 can you change the target branch to 5.4? So we could include it in the next minor release

@jopelle1 jopelle1 changed the base branch from 6.0.x to 5.4.x January 25, 2022 09:04
@jopelle1 jopelle1 requested a review from jimschubert as a code owner January 25, 2022 09:04
@jopelle1
Copy link
Copy Markdown
Author

@jopelle1 can you change the target branch to 5.4? So we could include it in the next minor release
@macjohnny Done !

@macjohnny
Copy link
Copy Markdown
Member

And please also rebase to the master branch, otherwise we get a huge list of changes

@jopelle1 jopelle1 changed the base branch from 5.4.x to master January 27, 2022 11:06
@jopelle1 jopelle1 changed the base branch from master to 5.4.x January 27, 2022 11:06
@jopelle1 jopelle1 changed the base branch from 5.4.x to master January 27, 2022 13:47
@jopelle1
Copy link
Copy Markdown
Author

And please also rebase to the master branch, otherwise we get a huge list of changes

Done !

@macjohnny
Copy link
Copy Markdown
Member

@jopelle1 closing this in favor of #9958, since the next release will be 6.0.0, so we can have a breaking change. thanks for your effort!

@macjohnny macjohnny closed this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants