Skip to content

dart2: Fix authentication#11360

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
provokateurin:fix/dart-generator-authentication
Apr 26, 2022
Merged

dart2: Fix authentication#11360
wing328 merged 2 commits intoOpenAPITools:masterfrom
provokateurin:fix/dart-generator-authentication

Conversation

@provokateurin
Copy link
Copy Markdown
Contributor

Fixes #7057

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

@provokateurin provokateurin changed the title Fix/dart generator authentication dart2: Fix authentication Jan 19, 2022
@provokateurin
Copy link
Copy Markdown
Contributor Author

@agilob If you approve, why doesn't this get merged?

@agilob
Copy link
Copy Markdown
Contributor

agilob commented Jan 25, 2022

best to have more approvals, also @wing328 needs to merge it

@provokateurin
Copy link
Copy Markdown
Contributor Author

Ah ok

@provokateurin
Copy link
Copy Markdown
Contributor Author

@agilob afaict the master branch now is 6.0.x? should i rebase against that and also merge into that?

@provokateurin
Copy link
Copy Markdown
Contributor Author

@wing328 could you review this before the 6.0.0 release? i think it's quite an important fix for dart clients.

@provokateurin provokateurin changed the base branch from 6.0.x to master April 13, 2022 15:42
@provokateurin
Copy link
Copy Markdown
Contributor Author

@agilob @wing328 I rebased onto the master branch, could this be merged at some point please?

@kuhnroyal
Copy link
Copy Markdown
Contributor

@agilob can you look over this again?

Copy link
Copy Markdown
Contributor

@agilob agilob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👀 but not trying this locally

@agilob
Copy link
Copy Markdown
Contributor

agilob commented Apr 23, 2022

@wing328 pls merge

@wing328 wing328 merged commit 37905e8 into OpenAPITools:master Apr 26, 2022
@wing328 wing328 added this to the 6.0.0 milestone Apr 26, 2022
@provokateurin provokateurin deleted the fix/dart-generator-authentication branch September 7, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][DART] Multiple security options are all being added instead of only one.

4 participants