[Ruby] Added Support for Binary Media Data Return#11254
Merged
wing328 merged 14 commits intoOpenAPITools:masterfrom Mar 23, 2022
Bandwidth-Sandbox:ckoegel-ruby-binary
Merged
[Ruby] Added Support for Binary Media Data Return#11254wing328 merged 14 commits intoOpenAPITools:masterfrom Bandwidth-Sandbox:ckoegel-ruby-binary
wing328 merged 14 commits intoOpenAPITools:masterfrom
Bandwidth-Sandbox:ckoegel-ruby-binary
Conversation
5 tasks
Member
|
@ckoegel thanks for the PR but looks like the change breaks the Ruby petstore tests: https://app.travis-ci.com/github/OpenAPITools/openapi-generator/builds/247572528 You can run the tests locally as well by running the test petstore server locally: https://github.com/OpenAPITools/openapi-generator/wiki/Integration-Tests#how-to-add-integration-tests-for-new-petstore-samples |
wing328
reviewed
Mar 21, 2022
wing328
reviewed
Mar 21, 2022
| request.url url | ||
| request.params = query_params | ||
| download_file(request) if opts[:return_type] == 'File' | ||
| download_file(request) if opts[:return_type] == 'File' || 'Binary' |
Member
There was a problem hiding this comment.
If I change this line to
download_file(request) if opts[:return_type] == 'File' || opts[:return_type] == 'Binary'the local tests pass. Can you give it a try?
Member
|
I just ran more tests to confirm the return type won't be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, only data return types of
StringandFileare supported, this PR allows for aBinaryreturn type, which returns the raw binary data from a gotten file. This data can be written to a file, allowing users to have the option to receive raw binary data without needed to download a temporary file. This can be validated by settingdebug_return_typeto 'Binary' when making a get request, and then writing the data received to a file.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x@cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)