Skip to content

[Dart] use LOGGER.debug instead of System.out.println#11128

Closed
wing328 wants to merge 1 commit intomasterfrom
improve-logging
Closed

[Dart] use LOGGER.debug instead of System.out.println#11128
wing328 wants to merge 1 commit intomasterfrom
improve-logging

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Dec 15, 2021

  • use LOGGER.debug instead of System.out.println
  • minor improvement to code format

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)

@kuhnroyal
Copy link
Copy Markdown
Contributor

This is my bad...

@wing328
Copy link
Copy Markdown
Member Author

wing328 commented Dec 15, 2021

No worries. No one complains. I spotted it when I was updating the samples.

*/
private void addBuiltValueSerializer(BuiltValueSerializer serializer) {
System.out.println("######## Add serializer!");
LOGGER.debug("######## Add serializer!");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log message doesn't say anything valuable, I'm for removing it.

@agilob
Copy link
Copy Markdown
Contributor

agilob commented Dec 15, 2021

@wing328 check my other PR, added test case to prevent this happening again #11130

@wing328
Copy link
Copy Markdown
Member Author

wing328 commented Dec 17, 2021

Merged via #11130 instead.

@wing328 wing328 closed this Dec 17, 2021
@wing328 wing328 deleted the improve-logging branch January 10, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants