Skip to content

[crystal] Add annotation to reserved key word list of crystal lang#10932

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
cyangle:crystal_annotation_keyword
Nov 23, 2021
Merged

[crystal] Add annotation to reserved key word list of crystal lang#10932
wing328 merged 2 commits intoOpenAPITools:masterfrom
cyangle:crystal_annotation_keyword

Conversation

@cyangle
Copy link
Copy Markdown
Contributor

@cyangle cyangle commented Nov 22, 2021

annotation is also reserved by crystal lang. Documentation is here.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 23, 2021

Thanks for the PR, which looks good to me.

@wing328 wing328 merged commit 8338962 into OpenAPITools:master Nov 23, 2021
@wing328 wing328 added this to the 5.3.1 milestone Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants