Skip to content

[dart-dio-next] Removes dioLibrary option#10931

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
josh-burton:revert-dart-dio-option
Dec 17, 2021
Merged

[dart-dio-next] Removes dioLibrary option#10931
wing328 merged 1 commit intoOpenAPITools:masterfrom
josh-burton:revert-dart-dio-option

Conversation

@josh-burton
Copy link
Copy Markdown
Contributor

As there is no longer a fork of the dio library this option can be removed
#10305

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • [x ] File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

@wing328
Copy link
Copy Markdown
Member

wing328 commented Dec 4, 2021

@ahmednfwela
Copy link
Copy Markdown
Contributor

@wing328 looks like a typical maven timeout

@wing328
Copy link
Copy Markdown
Member

wing328 commented Dec 4, 2021

Yup, I restarted it but no luck. Will give it another try tomorrow.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Dec 15, 2021

@josh-burton can you please resolve the merge conflicts when you've time? Then I'll merge. Thanks.

As there is no longer a fork of the dio library this option can be removed
@josh-burton josh-burton force-pushed the revert-dart-dio-option branch from 0c9f578 to 8a7ed9e Compare December 15, 2021 19:09
@wing328 wing328 merged commit 6f6d4f8 into OpenAPITools:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants