You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix broken generation of enum classes by removing unnecessary template code that broke the compilation of the generated code.
Testing
Reproducing the issue
To validate that this PR fixes the issue you should first reproduce the issue. This can be done on the master branch by generating the kotlin-multiplatform template code with the petstore-with-fake-endpoints-models-for-testing.yaml API spec, and then trying to compile the generated code:
The test fails due to several compilation errors. The errors that are relevant for the purpose of this PR, as reported in #10902 , can be observed in OuterEnum.kt and EnumClass.kt:
To validate that this PR fixes the issue, checkout this PR's code and re-run the two commands from above. The compile errors in OuterEnum.kt and EnumClass.kt are no longer present.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Hey @tkirshboim, thanks for opening this PR. Could you please run the following PR to generate the sample projects?
./mvnw clean package
./bin/generate-samples.sh
Thanks
@4brunu Thanks for the prompt response.
I've ran these commands and there are no local changes to commit when they've completed. This is probably because modules/openapi-generator/src/test/resources/2_0/petstore.yaml does not contain the enum definitions that cause the enum_class.mustache template to be used. This is the reason why I used petstore-with-fake-endpoints-models-for-testing.yaml to validate that the issue is resolved, as mentioned in the PR description.
I see. Did you test this in your local local project? Is it working?
@4brunu Yes. I was experiencing the same issue as #10902 and this change resolved the issue. The project compiled again and worked as expected with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Fixes #10902
Testing
Reproducing the issue
To validate that this PR fixes the issue you should first reproduce the issue. This can be done on the
masterbranch by generating thekotlin-multiplatformtemplate code with thepetstore-with-fake-endpoints-models-for-testing.yamlAPI spec, and then trying to compile the generated code:The test fails due to several compilation errors. The errors that are relevant for the purpose of this PR, as reported in #10902 , can be observed in
OuterEnum.ktandEnumClass.kt:To validate that this PR fixes the issue, checkout this PR's code and re-run the two commands from above. The compile errors in
OuterEnum.ktandEnumClass.ktare no longer present.CCs
Kotlin technical committee: @jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m
Reporter of #10902 : @Qbit982
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x