Skip to content

Fix response type string in javascript mustache template ISSUE #10833 #10916

Closed
code1x1 wants to merge 1 commit intoOpenAPITools:masterfrom
code1x1:bugfix/BUG-javascript-ApiClient-Fix-request-responseType-10833
Closed

Fix response type string in javascript mustache template ISSUE #10833 #10916
code1x1 wants to merge 1 commit intoOpenAPITools:masterfrom
code1x1:bugfix/BUG-javascript-ApiClient-Fix-request-responseType-10833

Conversation

@code1x1
Copy link
Copy Markdown
Contributor

@code1x1 code1x1 commented Nov 21, 2021

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jfiala @wing328

@code1x1
Copy link
Copy Markdown
Contributor Author

code1x1 commented Nov 21, 2021

bugfix pr for #10833

@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 22, 2021

Thanks for the PR. Can you please follow step 3 to update the samples as well so that the CI can verify the change?

@code1x1
Copy link
Copy Markdown
Contributor Author

code1x1 commented Nov 26, 2021

@wing328

executing these commands didnt yield any files to commit. Is that correct? When should these commands generate new files to commit?

./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh

@wing328 wing328 modified the milestones: 5.3.1, 5.4.0 Dec 29, 2021
@wing328 wing328 modified the milestones: 5.4.0, 6.0.0 Jan 31, 2022
@wing328 wing328 modified the milestones: 6.0.0, 6.0.1 May 26, 2022
@wing328 wing328 modified the milestones: 6.0.1, 6.1.0 Jul 5, 2022
@wing328 wing328 modified the milestones: 6.1.0, 6.1.1 Sep 11, 2022
@wing328 wing328 modified the milestones: 6.1.1, 6.2.1 Sep 24, 2022
@wing328 wing328 modified the milestones: 6.2.1, 6.3.0 Nov 1, 2022
@wing328 wing328 modified the milestones: 6.3.0, 6.3.1 Jan 20, 2023
@wing328 wing328 modified the milestones: 6.4.0, 6.5.0 Feb 19, 2023
@wing328 wing328 modified the milestones: 6.5.0, 6.6.0 Apr 1, 2023
@wing328 wing328 modified the milestones: 6.6.0, 7.0.0 May 11, 2023
@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 10, 2023

thanks for the PR. the issue has already fixed.

@wing328 wing328 closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants