[Kotlin][Multiplatform] Fix Kotlin Multiplatform Test#10900
[Kotlin][Multiplatform] Fix Kotlin Multiplatform Test#10900wing328 merged 3 commits intoOpenAPITools:masterfrom
Conversation
- Remove obsolete 'GRADLE_METADATA' Gradle preview flag from Kotlin Multiplatform settings.gradle template file. - Update Kotlin Version to 1.5.31 - Update coroutines, serialization and Ktor versions to the versions recommended for usage with Kotlin 1.5.31 see https://kotlinlang.org/docs/releases.html#release-details . Fixes OpenAPITools#10898
| val coroutines_version = "1.5.0" | ||
| val serialization_version = "1.2.1" | ||
| val ktor_version = "1.6.0" | ||
| val kotlin_version = "1.5.31" |
There was a problem hiding this comment.
@4brunu Jetpack Compose is not yet compatible with Kotlin 1.6.0. Using 1.6.0 would mean that KMM projects that use Compose might have issues using the multiplatform template. Since Compose is a popular UI library on Android, I thought to use 1.5.31, until Compose catches up - something that usually happens quite promptly.
There was a problem hiding this comment.
You are right 👍
Could you just update the serialization_version to 1.3.0, so that we only use stable versions?
| val ktor_version = "1.6.0" | ||
| val kotlin_version = "1.5.31" | ||
| val coroutines_version = "1.5.2" | ||
| val serialization_version = "1.3.0-RC" |
There was a problem hiding this comment.
@tkirshboim could you please update this to the stable version 1.3.1?
There was a problem hiding this comment.
@4brunu I can do that, but I chose this version because it is the recommended version to use with Kotlin 1.5.31 .
There was a problem hiding this comment.
I think we should use here the stable version 1.3.0.
| val kotlin_version = "1.5.31" | ||
| val coroutines_version = "1.5.2" | ||
| val serialization_version = "1.3.0-RC" | ||
| val ktor_version = "1.6.3" |
There was a problem hiding this comment.
@4brunu I chose this version because it is the recommended version to use with Kotlin 1.5.31 .
There was a problem hiding this comment.
Let's leave it the way it is.
|
@tkirshboim Hi, first of all, thanks for contributing with this PR 👍 |
4brunu
left a comment
4brunu
left a comment
There was a problem hiding this comment.
Thanks, looks good to me 👍
3 participants
PR Description
Fixes #10898
GRADLE_METADATAGradle preview flag from Kotlin Multiplatformsettings.gradle.kts.mustachetemplate file.coroutines,serializationandktorversions to the versions recommended for usage with Kotlin 1.5.31 (see https://kotlinlang.org/docs/releases.html#release-details).cleantask to the Kotlin Multiplatform templatepom.xmlfile to allow to easily clean the samples folder from previous build outputs.Testing
To validate that this PR fixes the issue, run the Kotlin Multiplatform test from the project's root folder and see that the test completes successfully.
CCs
Kotlin technical committee:
@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m
People working on previous change #10468 : @shadowsheep1
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x