Skip to content

Non functional Java styling changes#10808

Merged
wing328 merged 9 commits intoOpenAPITools:masterfrom
agilob:java-warning-formatting
Nov 9, 2021
Merged

Non functional Java styling changes#10808
wing328 merged 9 commits intoOpenAPITools:masterfrom
agilob:java-warning-formatting

Conversation

@agilob
Copy link
Copy Markdown
Contributor

@agilob agilob commented Nov 7, 2021

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@agilob
Copy link
Copy Markdown
Contributor Author

agilob commented Nov 7, 2021

@wing328 @jimschubert

@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 9, 2021

LGTM

cc @OpenAPITools/generator-core-team

@wing328 wing328 added this to the 5.3.1 milestone Nov 9, 2021
@wing328 wing328 added the Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. label Nov 9, 2021
@wing328 wing328 merged commit 4d947a1 into OpenAPITools:master Nov 9, 2021
@agilob agilob deleted the java-warning-formatting branch November 9, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants