[Bash] Support post form data#10795
Merged
wing328 merged 7 commits intoOpenAPITools:masterfrom Nov 9, 2021
Merged
Conversation
wing328
reviewed
Nov 9, 2021
|
|
||
| # Make POST request with form data | ||
| $ {{scriptName}} --host <hostname> <operationId> key1:=value1 key2:=value2 key3:=23 | ||
|
|
Member
There was a problem hiding this comment.
FYI. We can accept this enhancement to start with but 2 things:
- some APIs do not have POST methods
- users may have no clue what
operationIdis (I saw other part of the PR is already using it but I hope you see my point)
I think a better way is to support auto-generate documentation in the Bash client. Please let me know if you've time for the contribution and I can share some good starting points with you.
Contributor
Author
There was a problem hiding this comment.
Sure. I can work on the following enhancement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the fix, the bash client cannot handle post form data.
After the fix, it can send post data.
Fix #4251
example generated curl command
example yaml
https://gist.github.com/kevchentw/9ab2df64c8ce8247a1edc607eed2843f
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x@frol (2017/07) @bkryza (2017/08) @kenjones-cisco (2017/09)