Skip to content

Fixed broken form params in typescript-angular client (#10776)#10777

Merged
macjohnny merged 2 commits intoOpenAPITools:masterfrom
beckerjohannes:fix/10776-multipart-upload
Nov 4, 2021
Merged

Fixed broken form params in typescript-angular client (#10776)#10777
macjohnny merged 2 commits intoOpenAPITools:masterfrom
beckerjohannes:fix/10776-multipart-upload

Conversation

@beckerjohannes
Copy link
Copy Markdown
Contributor

@beckerjohannes beckerjohannes commented Nov 4, 2021

Fixes #10776 the broken form params for typescript angular client introduced by search&replace refactoring in #10020.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Please re-generate the samples.

@macjohnny macjohnny added this to the 5.3.1 milestone Nov 4, 2021
@macjohnny
Copy link
Copy Markdown
Member

@beckerjohannes
Copy link
Copy Markdown
Contributor Author

I wonder why this was not caught in the unit tests in https://github.com/OpenAPITools/openapi-generator/tree/461d21161d876889b4e3a236acca29b96dd40366/samples/client/petstore/typescript-angular-v7-provided-in-root/tests/default/src/test

@beckerjohannes would you like to look into that?

I would say, because the uploadFile Method which is the mulitpart-form-data sample of the petstore api is not tested in the test file you linked. However, my typescript know how is too limited to fix this. Considering myself more as java backend guy. ;-)

@macjohnny macjohnny merged commit 40018c3 into OpenAPITools:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][typescript-angular] Refactoring in #10020 broke multipart file upload

2 participants