Skip to content

[java][okhttp] Fix authentication bug in query collection parameters#10768

Merged
wing328 merged 1 commit intomasterfrom
fix-auth
Nov 3, 2021
Merged

[java][okhttp] Fix authentication bug in query collection parameters#10768
wing328 merged 1 commit intomasterfrom
fix-auth

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Nov 3, 2021

-Fix bug (authentication setting) in query collection parameters. Before the fix, collectionQueryParams were not updated with authentication settings.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

@wing328 wing328 added this to the 5.3.1 milestone Nov 3, 2021
@wing328 wing328 marked this pull request as ready for review November 3, 2021 09:41
@wing328 wing328 changed the title [java][okhttp] Fix bug in query collection parameters [java][okhttp] Fix authentication bug in query collection parameters Nov 3, 2021
@wing328 wing328 merged commit 9d1420d into master Nov 3, 2021
@wing328 wing328 deleted the fix-auth branch November 3, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant