Skip to content

[crystal][client][closes #10700] Remove .rspec and .rubycop.yml from crystal client#10701

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
cyangle:remove_rspec_and_rubocop_yml_files_from_crystal_client_generator
Oct 26, 2021
Merged

[crystal][client][closes #10700] Remove .rspec and .rubycop.yml from crystal client#10701
wing328 merged 1 commit intoOpenAPITools:masterfrom
cyangle:remove_rspec_and_rubocop_yml_files_from_crystal_client_generator

Conversation

@cyangle
Copy link
Copy Markdown
Contributor

@cyangle cyangle commented Oct 26, 2021

@wing328 , please review
Closes #10700, removes .rspec and .rubycop.yml from crystal client

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added Client: Crystal Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Oct 26, 2021
@wing328 wing328 added this to the 5.3.1 milestone Oct 26, 2021
@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 26, 2021

LGTM. Thanks for the PR.

@wing328 wing328 merged commit 01a4569 into OpenAPITools:master Oct 26, 2021
@cyangle cyangle deleted the remove_rspec_and_rubocop_yml_files_from_crystal_client_generator branch October 26, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: Crystal Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][crystal][client] .rspec and .rubocop.yml should be removed

2 participants