Skip to content

[scala-akka-http-server] Fix array optional parameter invalid default value#10676

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
krrrr38:issue/10675
Nov 3, 2021
Merged

[scala-akka-http-server] Fix array optional parameter invalid default value#10676
wing328 merged 1 commit intoOpenAPITools:masterfrom
krrrr38:issue/10675

Conversation

@krrrr38
Copy link
Copy Markdown
Contributor

@krrrr38 krrrr38 commented Oct 24, 2021 •
edited
Loading

see #10675

  • ASIS
> ./mvnw clean install
> java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate \
  -g scala-akka-http-server \
  -i petstore-optional-array-parameter.yaml \
  -o /var/tmp/scala-akka-http-server
> grep findByStatus -A4 /var/tmp/scala-akka-http-server/src/main/scala/org/openapitools/server/api/PetApi.scala
    path("pet" / "findByStatus") {
      get {
        parameters("status".as[String].?("new ListBuffer[String]() ")) { (status) =>
            petService.findPetsByStatus(status = status)
        }
  • TOBE
> ./mvnw clean install
> java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate \
  -g scala-akka-http-server \
  -i petstore-optional-array-parameter.yaml \
  -o /var/tmp/scala-akka-http-server
> grep findByStatus -A4 /var/tmp/scala-akka-http-server/src/main/scala/org/openapitools/server/api/PetApi.scala
    path("pet" / "findByStatus") {
      get {
        parameters("status".as[String].?) { (status) =>
            petService.findPetsByStatus(status = status)
        }
> # service also become recieving optional value
> grep findPetsByStatus /var/tmp/scala-akka-http-server/src/main/scala/org/openapitools/server/api/PetApi.scala
            petService.findPetsByStatus(status = status)
  def findPetsByStatus200(responsePetarray: Seq[Pet])(implicit toEntityMarshallerPetarray: ToEntityMarshaller[Seq[Pet]]): Route =
  def findPetsByStatus400: Route =
  def findPetsByStatus(status: Option[String])

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

krrrr38
krrrr38 commented Oct 24, 2021
View reviewed changes
Comment thread ...i-generator/src/main/java/org/openapitools/codegen/languages/ScalaAkkaHttpServerCodegen.java Outdated
Copy link
Copy Markdown
Contributor Author

@krrrr38 krrrr38 Oct 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except primitiveParamTypes, there is no support in akka-http-server. So removed default value too.

@krrrr38 krrrr38 force-pushed the issue/10675 branch 2 times, most recently from 41d9ed1 to 7065416 Compare October 24, 2021 10:12
@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 3, 2021

Tested this change and got

    path("pet" / "findByStatus") { 
      get { 
        parameters("status".as[String].?) { (status) => 
            petService.findPetsByStatus(status = status)
        }

and it compiles without issues so I'll go ahead to merge it into master. Thanks for the PR.

@wing328 wing328 merged commit 359e393 into OpenAPITools:master Nov 3, 2021
@wing328 wing328 added this to the 5.3.1 milestone Nov 3, 2021
@krrrr38 krrrr38 deleted the issue/10675 branch November 3, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Issue: Bug Server: Scala

Projects

None yet

Milestone

5.3.1

Development

Successfully merging this pull request may close these issues.

2 participants

@krrrr38 @wing328