Skip to content

[kotlin-spring] change the suffix from ".kt" to "Controller.kt" when generating a controller class#10671

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
martinsaison:fix/10670
Oct 29, 2021
Merged

[kotlin-spring] change the suffix from ".kt" to "Controller.kt" when generating a controller class#10671
wing328 merged 3 commits intoOpenAPITools:masterfrom
martinsaison:fix/10670

Conversation

@martinsaison
Copy link
Copy Markdown
Contributor

… (#10670)

  • Method KotlinSpringServerCodegen.processOpts() has been updated to replace ".kt" with "Controller.kt" when adding the template file api.mustache to match the filename and the class name.
  • Unit tests updated to match the correct filenames.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @jimschubert @karismann @Zomzog @andrewemery @4brunu @yutaka0m

@4brunu
Copy link
Copy Markdown
Contributor

4brunu commented Oct 24, 2021

Looks good to me 👍

@wing328 wing328 changed the title fix: [kotlin-spring] change the suffix from ".kt" to "Controller.kt" in when generating a controller class from the template api.mustache to match the class name [kotlin-spring] change the suffix from ".kt" to "Controller.kt" when generating a controller class Oct 29, 2021
@wing328 wing328 added this to the 5.3.1 milestone Oct 29, 2021
@wing328 wing328 merged commit a33a0fd into OpenAPITools:master Oct 29, 2021
AndersSpringborg added a commit to Forsteholdet/openapi-generator that referenced this pull request Oct 31, 2021
* OpenAPITools-master: (457 commits)
  [java][jersey2] remove warning using JsonMapper.builder (OpenAPITools#10734)
  update scribejava to 8.x (OpenAPITools#10733)
  [powershell] add file upload support (OpenAPITools#10735)
  Add openapi-generator kotlin article (OpenAPITools#10731)
  [ts-angular]: add ts-ignore directives to avoid compilation errors (OpenAPITools#10713)
  rebalance circleci tests (OpenAPITools#10727)
  [java][okhttp-gson] update dependencies in pom.xml (OpenAPITools#10709)
  [java][jersey2] update plugins in pom.xml (OpenAPITools#10710)
  Fix library generation compatibility with Gradle 7.2 (OpenAPITools#10716)
  [kotlin-spring] change the suffix from ".kt" to "Controller.kt" when generating a controller class (OpenAPITools#10671)
  [cpprestsdk] CMake build system improvements (OpenAPITools#10660)
  adds get/setHasMultipleTypes to Java schema classes (OpenAPITools#10715)
  update microprofile to newer version (OpenAPITools#10714)
  Typescript saga immutablejs enhancements and small fixes (OpenAPITools#10444)
  add an option for configKey (OpenAPITools#10707)
  Allow specification of configkey for microprofile clients (OpenAPITools#10693)
  Update crystal client gitignore.mustache with shards related files (OpenAPITools#10698)
  Adds ComposedSchema to store schema composed schemas (OpenAPITools#10653)
  Adds setPrettyPrint and the reslver MethodValueResolver.INSTANCE (OpenAPITools#10683)
  [dart] Fix pub server URL (OpenAPITools#10695)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants