Skip to content

[Python] Remove virtualenv deprecated option from test scripts.#10666

Merged
spacether merged 2 commits intoOpenAPITools:masterfrom
tomplus:chore/virtualenv-no-site-packages
Oct 23, 2021
Merged

[Python] Remove virtualenv deprecated option from test scripts.#10666
spacether merged 2 commits intoOpenAPITools:masterfrom
tomplus:chore/virtualenv-no-site-packages

Conversation

@tomplus
Copy link
Copy Markdown
Member

@tomplus tomplus commented Oct 22, 2021

In scripts which run tests virtualenv is used with option --no-site-packages. This option was deprecated for a long time and has been removed recently.

Ref: https://virtualenv.pypa.io/en/legacy/reference.html#cmdoption-no-site-packages and pypa/virtualenv#1681

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc: @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)

Thanks!

@spacether spacether added this to the 5.3.0 milestone Oct 23, 2021
Copy link
Copy Markdown
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR; looks good!

@spacether spacether merged commit b1950dd into OpenAPITools:master Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants