Skip to content

Remove invalid argument in newer version of JVM#10652

Merged
wing328 merged 1 commit intomasterfrom
remove_invalid_arg
Oct 22, 2021
Merged

Remove invalid argument in newer version of JVM#10652
wing328 merged 1 commit intomasterfrom
remove_invalid_arg

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Oct 21, 2021

Remove invalid argument in pom.xml, which results in issues in newer versions of JVM

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 5.3.0 milestone Oct 21, 2021
@wing328 wing328 marked this pull request as ready for review October 22, 2021 01:14
@wing328 wing328 merged commit fa5401b into master Oct 22, 2021
@agilob
Copy link
Copy Markdown
Contributor

agilob commented Oct 22, 2021

I started working on updating config and syntactic changes for java 11 here https://github.com/OpenAPITools/openapi-generator/compare/master...agilob:update-jdk?expand=1

It's not finished, but this line you changed here was part of my changes, I'll open PR with these changes next week

@wing328 wing328 deleted the remove_invalid_arg branch October 23, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants