Fix import mappings for service in angular typescript#10644
Merged
macjohnny merged 4 commits intoOpenAPITools:masterfrom Oct 26, 2021
Merged
Conversation
amakhrov
approved these changes
Oct 25, 2021
Contributor
amakhrov
left a comment
There was a problem hiding this comment.
Thanks for your contribution! The fix look good to me.
Seems that you still need to regenerate samples (bin/generate-samples.sh)
Contributor
|
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) |
…o fix_#5079_import_mappings_for_typescript_angular_service
6 tasks
|
@rudolficzek @macjohnny @amakhrov This is not working when using something like in the generator configuration. The imports from the but it should be as the file is named |
Member
|
@ToppScorer do you want to fix this? |
Unfortunately I'm too busy right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5079
Currently line https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache#L12 causes everything to be imported from ../model/models
So for a mapping :
"importMappings": {
"MyObject": "@company/mylib"
}
actual is:
import { MyObject} from '../model/models';
Expected:
import { MyObject} from '@company/mylib';
Solution exist in typescript-node to handle that. Pr aligns two generators to be symmetric
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x@petejohansonxo
@amakhrov