Skip to content

Add try-with-resources to unclosed streams#10641

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
artwo:closing-open-streams
Oct 21, 2021
Merged

Add try-with-resources to unclosed streams#10641
wing328 merged 1 commit intoOpenAPITools:masterfrom
artwo:closing-open-streams

Conversation

@artwo
Copy link
Copy Markdown
Contributor

@artwo artwo commented Oct 19, 2021

This PR improves the handling of input and output streams by using the try-with-resources statement to ensure that they are closed. There is a correction on how the try-with-resources is used with multiple streams which is based in this documentation.

The PR is meant to fix the remaining sonarcloud issues of #788.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@artwo artwo requested a review from jimschubert as a code owner October 19, 2021 21:28
@artwo artwo changed the title add try-with-resources statement to unclosed streams Add try-with-resources to unclosed streams Oct 19, 2021
@artwo
Copy link
Copy Markdown
Contributor Author

artwo commented Oct 20, 2021

I am not very sure what is failing in the circleci. Could you please have a look?

@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 20, 2021

I don't think it's related to this change as it happens in other PRs as well. We'll take a look.

Thanks for the PR.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 21, 2021

CircleCI failure already fixed in the master.

@wing328 wing328 merged commit 108e8e5 into OpenAPITools:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants