Skip to content

[kotlin][client] add base url key#10633

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
4brunu:feature/kotlin-base-url-key
Nov 2, 2021
Merged

[kotlin][client] add base url key#10633
wing328 merged 3 commits intoOpenAPITools:masterfrom
4brunu:feature/kotlin-base-url-key

Conversation

@4brunu
Copy link
Copy Markdown
Contributor

@4brunu 4brunu commented Oct 19, 2021

Currently there is no safe way to access the base url key, to set in the system properties.
This PR fixes this.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@4brunu
Copy link
Copy Markdown
Contributor Author

4brunu commented Oct 19, 2021

@wing328 I don't know why CI is failing, I tried to reproduce the error locally, but it works on my machine.
Could you please help?
Thanks

@4brunu 4brunu closed this Oct 19, 2021
@4brunu 4brunu reopened this Oct 19, 2021
@wing328 wing328 added this to the 5.3.1 milestone Nov 2, 2021
@wing328 wing328 merged commit 57afa97 into OpenAPITools:master Nov 2, 2021
@4brunu 4brunu deleted the feature/kotlin-base-url-key branch December 14, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants