Improve Apache Httpclient support#10624
Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom Oct 23, 2021
Merged
Conversation
Member
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
78ec21d to
a9ddd84
Compare
a9ddd84 to
ceca669
Compare
Contributor
Author
|
Commits authors fixed and force pushed. The circleci PR check failed, but the failure doesn't seem to be caused by the code changes. |
Member
|
Tested locally and the result is good. Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Apache Httpclient template files moved to proper directory, after this they should work when used with
--additional-properties library=apache-httpclientCLI option.Sample files were regenerated and they really use the
apache-httpclientand compile properly (using both Gradle and MVN).I think this could be merged to all branches where
apache-httpclientis present (and probably should be merged, as without this it's not possible to easily use this library).Before
Before the fix when
--additional-properties library=apache-httpclientCLI option was used the default Java library was used.Also there was no specific
build.gradlecreated to properly compile the code using Apache Httpclient.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.xJava Technical Commitee, please review:
CC @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)
FYI @harrywhite4