Skip to content

[Csharp][aspnet] Aspnet 6.0 Support#10619

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
Blackclaws:aspnet6
Feb 19, 2022
Merged

[Csharp][aspnet] Aspnet 6.0 Support#10619
wing328 merged 2 commits intoOpenAPITools:masterfrom
Blackclaws:aspnet6

Conversation

@Blackclaws
Copy link
Copy Markdown
Contributor

Aspnet 6.0 is almost upon us. This pull request introduces basic generation capabilities. The generated code won't run until the 6.0.0 packages are published, so maybe we delay the merge until 10.11.

In general we might want to think about getting rid of the support for aspnet 2.1 and below, would simplify a lot of the code and its out of support anyway.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @lucamazzanti (2021/05)

@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 19, 2022

Tested locally and the output compiles without any issue. Will add tests later.

@wing328 wing328 merged commit c161358 into OpenAPITools:master Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants