[TypeScript][FIX] Missing typescript reserved word#10587
Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom Oct 19, 2021
Merged
[TypeScript][FIX] Missing typescript reserved word#10587macjohnny merged 1 commit intoOpenAPITools:masterfrom
macjohnny merged 1 commit intoOpenAPITools:masterfrom
Conversation
amakhrov
reviewed
Oct 17, 2021
Contributor
There was a problem hiding this comment.
from is not a reserved TS keyword. It's just a variable that is already defined in the context of a particular template. They all are listed in the same set - just bucketed separately for readablity (see "local variable names" bucket on lines 112-113 above).
Furthermore, I believe this from is only used in a generic typescript client (TypeScriptClientCodegen), which doesn't extend this AbstractTypeScriptClientCodegen. I looks like you need to apply this change to TypeScriptClientCodegen and revert it here
Contributor
Author
There was a problem hiding this comment.
Should be fixed :) thanks for your input !
AlexMog
force-pushed
the
fix_typescript_missing_reserved_word
branch
from
fb6b08d to
ea6f557
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.xFixes: #10584