Skip to content

Fixes doubles type as &str&str for type:string; format:uuid parameter#10569

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
Dema:rust-strstr-fix
Oct 9, 2021
Merged

Fixes doubles type as &str&str for type:string; format:uuid parameter#10569
wing328 merged 1 commit intoOpenAPITools:masterfrom
Dema:rust-strstr-fix

Conversation

@Dema
Copy link
Copy Markdown
Contributor

@Dema Dema commented Oct 9, 2021

Do'not output &str for isString if it is also isUuid

This fixes #10568. Added an "else" clause if it is a string and also an uuid. In this case we shouldn't output &str for string
because is already outputs for uuid. I'm not sure if it is correct way to do it. Maybe it will be better to do
{{#isUuiud}}{{^isString}}&str...

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @paladinzh

Do'not output &str for isString if it is also isUuid
@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 9, 2021

cc @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05)

@wing328 wing328 added this to the 5.3.0 milestone Oct 9, 2021
@wing328 wing328 changed the title Fixes #10568 Fixes doubles type as &str&str for type:string; format:uuid parameter Oct 9, 2021
@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 9, 2021

LGTM but I've not tested it locally

@wing328 wing328 merged commit efa032a into OpenAPITools:master Oct 9, 2021
@JMLX42
Copy link
Copy Markdown
Contributor

JMLX42 commented Dec 9, 2024

@Dema thank you for this fix! Any reason why UUIDs are not actually typed as Uuid (instead of &str) though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Rust client generator doubles type as &str&str for type:string; format:uuid parameter

3 participants