Skip to content

Ruby: Fix deprecation warning for Faraday#10559

Merged
wing328 merged 3 commits intomasterfrom
Faraday-request
Oct 8, 2021
Merged

Ruby: Fix deprecation warning for Faraday#10559
wing328 merged 3 commits intomasterfrom
Faraday-request

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Oct 8, 2021

Redo #10558 with the correct file

Removed modules/openapi-generator/src/main/resources/crystal/api_client_faraday_partial.mustache as it's not used by the Crystal client generator

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member Author

wing328 commented Oct 8, 2021

@wing328 wing328 merged commit 08296c2 into master Oct 8, 2021
@wing328 wing328 deleted the Faraday-request branch October 8, 2021 04:06
@wing328 wing328 added Client: Ruby Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Oct 8, 2021
@wing328 wing328 added this to the 5.3.0 milestone Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: Ruby Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant