Skip to content

Ruby: Fix deprecation warning for Faraday#10558

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
OrelSokolov:patch-1
Oct 8, 2021
Merged

Ruby: Fix deprecation warning for Faraday#10558
wing328 merged 1 commit intoOpenAPITools:masterfrom
OrelSokolov:patch-1

Conversation

@OrelSokolov
Copy link
Copy Markdown
Contributor

@OrelSokolov OrelSokolov commented Oct 7, 2021

To avoid this warnings while running rspecs

WARNING: `Faraday::Connection#basic_auth` is deprecated; it will be removed in version 2.0.
While initializing your connection, use `#request(:basic_auth, ...)` instead.
See https://lostisland.github.io/faraday/middleware/authentication for more usage info.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

To avoid this warnings while running rspecs
```
WARNING: `Faraday::Connection#basic_auth` is deprecated; it will be removed in version 2.0.
While initializing your connection, use `#request(:basic_auth, ...)` instead.
See https://lostisland.github.io/faraday/middleware/authentication for more usage info.
```
@OrelSokolov OrelSokolov changed the title Fix deprecation warning for Faraday Ruby: Fix deprecation warning for Faraday Oct 7, 2021
@OrelSokolov
Copy link
Copy Markdown
Contributor Author

@cliffano @zlx @autopp

@wing328 wing328 added Client: Ruby Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Oct 8, 2021
@wing328 wing328 added this to the 5.3.0 milestone Oct 8, 2021
@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 8, 2021

Ruby tests with updated samples passed via https://app.travis-ci.com/github/OpenAPITools/openapi-generator/builds/239390550.

I'll update the samples after merging this PR into master.

@wing328 wing328 merged commit 8b8654f into OpenAPITools:master Oct 8, 2021
@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 8, 2021

Actually you updated the wrong file in the crystal folder. I've redo the change in the correct file via #10559

@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 8, 2021

Thanks again for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: Ruby Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants