Skip to content

[csharp-netcore]For conditionalSerialization do not initialize the default value.#10551

Merged
wing328 merged 8 commits intoOpenAPITools:masterfrom
Ghufz:fix_default_value
Oct 12, 2021
Merged

[csharp-netcore]For conditionalSerialization do not initialize the default value.#10551
wing328 merged 8 commits intoOpenAPITools:masterfrom
Ghufz:fix_default_value

Conversation

@Ghufz
Copy link
Copy Markdown
Contributor

@Ghufz Ghufz commented Oct 7, 2021

Added allowDefaultValue flag in config file for c# SDK.

  • This flag works with conditionalSerialization flag. It gives the flexibility to the user to provide the default value based on this flag.
  • By default allowDefaultValue is set to true which means it assign the properties which has default value.
  • If allowDefaultValue is set to false , it does not assign properties with its default value specified in openAPI doc.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @wing328

@Ghufz Ghufz changed the title added allowDefaultValue flag for conditionSerialization [csharp-netcore]added allowDefaultValue flag for conditionSerialization Oct 7, 2021
@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 10, 2021

cc @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05)

@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 11, 2021

Updated samples and docs via f40e5f4

@Ghufz Ghufz changed the title [csharp-netcore]added allowDefaultValue flag for conditionSerialization [csharp-netcore]For conditionalSerialization do not initialize the default value. Oct 11, 2021
@wing328 wing328 merged commit b4206ad into OpenAPITools:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants