[cpp][qt] Start cleanup of cpp qt readme#10549
Merged
wing328 merged 4 commits intoOpenAPITools:masterfrom Oct 13, 2021
xconverge:updateCppQtReadme
Merged
[cpp][qt] Start cleanup of cpp qt readme#10549wing328 merged 4 commits intoOpenAPITools:masterfrom xconverge:updateCppQtReadme
wing328 merged 4 commits intoOpenAPITools:masterfrom
xconverge:updateCppQtReadme
Conversation
Contributor
|
Indeed. After a quick look here are some suggestion:
|
Contributor
Author
|
Sounds good, I think this is a better sane starting point now :) |
Contributor
|
The links in the following paragraph are dead:
I would suggest to remove the link since there is specific generators for the documentation. |
xconverge
commented
Oct 8, 2021
|
|
||
|
|
||
| ## Documentation for Authorization | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@MartinDelille I think this section could be removed too?
"## Documentation for Authorization"
Member
There was a problem hiding this comment.
I think we should keep it to show users whether this API requires authorisation or not.
MartinDelille
suggested changes
Oct 12, 2021
Member
|
LGTM |
Member
|
cc @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unless I am severely confused... this readme needs some love, so just starting a little bit of the no brainer cleanup.
@etherealjoy @MartinDelille
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x