Skip to content

[Java] add an option to customize gradle.properties#10540

Merged
wing328 merged 2 commits intomasterfrom
gradle-properties-option
Oct 8, 2021
Merged

[Java] add an option to customize gradle.properties#10540
wing328 merged 2 commits intomasterfrom
gradle-properties-option

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Oct 6, 2021

  • add an option to customize gradle.properties

To close #10527

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

@agilob
Copy link
Copy Markdown
Contributor

agilob commented Oct 6, 2021

Can this be added to abstractjavacodegen so groovy and spring generators can get it for free?

image

@wing328
Copy link
Copy Markdown
Member Author

wing328 commented Oct 6, 2021

I suggest we do it later in the generator class itself instead of abstract java class as not all generators extending abstract java class supports gradle (e.g. java inflector server generator)

@wing328 wing328 merged commit 96c65fe into master Oct 8, 2021
@wing328 wing328 deleted the gradle-properties-option branch October 8, 2021 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] Java client: allow customizing content of generated gradle.properties

2 participants