Skip to content

Add message and more context to RequiredError#10530

Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom
bodograumann:typescript-fix-required-error-usage
Oct 5, 2021
Merged

Add message and more context to RequiredError#10530
macjohnny merged 1 commit intoOpenAPITools:masterfrom
bodograumann:typescript-fix-required-error-usage

Conversation

@bodograumann
Copy link
Copy Markdown
Contributor

Changes the RequiredError exceptions class to retain the api class, method and field names as context.
Most importantly the actual error message is now in the message field, where it belongs.
Added an integration test to check it works. Verify with:

mvn integration-test -f samples/openapi3/client/petstore/typescript/tests/default/pom.xml

Fixes #10459

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny added this to the 5.3.0 milestone Oct 5, 2021
@macjohnny macjohnny merged commit 9aadd77 into OpenAPITools:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [Typescript] Wrong usage of RequiredError

2 participants