Skip to content

Fix Windows build failure in some environments#10529

Merged
wing328 merged 13 commits intomasterfrom
surefire-fix
Oct 5, 2021
Merged

Fix Windows build failure in some environments#10529
wing328 merged 13 commits intomasterfrom
surefire-fix

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Oct 5, 2021

Fix Windows build failure in some environments due to line break setting by removing line breaks when comparing auto-generated files.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 5.3.0 milestone Oct 5, 2021
@wing328 wing328 changed the title Fix Windows build failure in some environment Fix Windows build failure in some environments Oct 5, 2021
@wing328 wing328 merged commit 72cec10 into master Oct 5, 2021
@wing328 wing328 deleted the surefire-fix branch October 5, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant