Skip to content

Correct a dependency resolution failure in generated angular typescript packages for Angular 12#10525

Merged
macjohnny merged 2 commits intoOpenAPITools:masterfrom
AppliedBioMath:master
Oct 5, 2021
Merged

Correct a dependency resolution failure in generated angular typescript packages for Angular 12#10525
macjohnny merged 2 commits intoOpenAPITools:masterfrom
AppliedBioMath:master

Conversation

@andrew-matteson
Copy link
Copy Markdown
Contributor

Fixes: #10523

NB: tsickle: 0.43 requires typescript: 4.3.x so increased minimum version too.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce (@akehir @petejohansonxo @amakhrov

Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny merged commit 22d98c1 into OpenAPITools:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular Typescript client has a dependency resolution failure when generated as an npm package

3 participants