[typescript-axios] Fix invalid query params usage#10512
Merged
macjohnny merged 2 commits intoOpenAPITools:masterfrom Oct 3, 2021
Merged
[typescript-axios] Fix invalid query params usage#10512macjohnny merged 2 commits intoOpenAPITools:masterfrom
macjohnny merged 2 commits intoOpenAPITools:masterfrom
Conversation
Remove passing query params from options to setSearchParams. Options were already passed to Axios in full so this removes some duplicate logic. Axios does merge query params given in path and through params option so no change in outcome.
5 tasks
Member
|
@aiven-hh thanks a lot for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything from options is already passed to Axios in
openapi-generator/modules/openapi-generator/src/main/resources/typescript-axios/apiInner.mustache
Line 57 in c2c4ba5
openapi-generator/modules/openapi-generator/src/main/resources/typescript-axios/common.mustache
Line 124 in c2c4ba5
options.queryfrom being passed tosetSearchParamsis fine because Axios can merge query params frompath(wheresetSearchParamsresult ends up in) and fromoptions(where all othed params end up in). This also fixes the issue thatoptions.querydoes not actually exists and the correct parameter isoptions.paramswhich is now typed correctly (changed in #10447).PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x