Skip to content

[Kotlin] Fix prevent string default value to be escaped#10501

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
Fs02:fix-string-default-value-for-kotlin
Oct 2, 2021
Merged

[Kotlin] Fix prevent string default value to be escaped#10501
wing328 merged 1 commit intoOpenAPITools:masterfrom
Fs02:fix-string-default-value-for-kotlin

Conversation

@Fs02
Copy link
Copy Markdown
Contributor

@Fs02 Fs02 commented Oct 1, 2021

  • Fix prevent string default value with quote (ex: "string value") to be escaped

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc: @jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m

@4brunu
Copy link
Copy Markdown
Contributor

4brunu commented Oct 1, 2021

Hey, thanks for this PR.
Did you run the following commands to update the sample projects?

./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh

Thanks

@Fs02
Copy link
Copy Markdown
Contributor Author

Fs02 commented Oct 1, 2021

Hey, thanks for this PR. Did you run the following commands to update the sample projects?

./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh

Thanks

Hi, I did run the command, but seems the samples doesn’t contains any string value, so nothing is changed

@4brunu
Copy link
Copy Markdown
Contributor

4brunu commented Oct 1, 2021

Thanks 👍
Looks good to me

@wing328 wing328 added this to the 5.3.0 milestone Oct 2, 2021
@wing328 wing328 merged commit 68285bc into OpenAPITools:master Oct 2, 2021
@Fs02 Fs02 deleted the fix-string-default-value-for-kotlin branch October 2, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants