[Java] Fix Potential Flaky Tests#10485
Merged
wing328 merged 7 commits intoOpenAPITools:masterfrom Sep 28, 2021
Merged
Conversation
Member
|
LGTM. Will merge after all tests pass |
Member
|
Failed tests already fixes in the master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some potential flaky tests in
org.openapitools.codegen.java.AbstractJavaCodegenTestfile.In these tests, we assigned some hardcoded elements into the
codegen'sAdditionalModelTypeAnnotations.However, according to the code where we set this value, we split the input string by a regex, convert it to a
HashSet, and store in anArrayList:The problem is that HashSet is not guarantee that the order will remain constant over time according to the Java documentation. Thus, these assertions will fail in some platforms or specific machines that adopt a different iteration order.
To fix it, I sort the both
additionalModelTypeAnnotationsandcodegen.getAdditionalModelTypeAnnotations()to make sure that their order is deterministic.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x