Use packageName in all of install instructions#10480
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Sep 28, 2021
Merged
Use packageName in all of install instructions#10480wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
Thanks for fixing the issue with the non-templatized package name in the install instructions. I'm submitting this slight improvement to - instruct the user to name the folder after the packageName - set the path to that new folder name
Member
|
LGTM. Thanks for the enhancement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for fixing the issue with the non-templatized package name in the install instructions. I'm submitting this slight improvement to
None of this is breaking as is, this is purely an suggested update to the README language to help newer user not have to extrapolate things that more experienced user would just intuitively understand.
@frol @farcaller @richardwhiuk @paladinzh
PR checklist